Skip to content

Conversation

svozza
Copy link
Contributor

@svozza svozza commented Sep 9, 2025

Summary

Improves the type guard that checks whether we have received a validAPIGatewayProxyEvent by handling all its nullable fields.

Changes

  • Updated the isAPIGatewayProxyEvent function
  • Added new tests to ensure we catch all possible nullable fields.

Issue number: closes #4454


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@svozza svozza self-assigned this Sep 9, 2025
@boring-cyborg boring-cyborg bot added event-handler This item relates to the Event Handler Utility tests PRs that add or change tests labels Sep 9, 2025
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Sep 9, 2025
@svozza svozza requested review from dreamorosi and sdangol September 9, 2025 18:44
Copy link

sonarqubecloud bot commented Sep 9, 2025

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch simplifying the tests!

@svozza svozza merged commit 200f47b into main Sep 9, 2025
38 checks passed
@svozza svozza deleted the event-handler/fix-nullable-fields-apigw-test branch September 9, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

event-handler This item relates to the Event Handler Utility size/L PRs between 100-499 LOC tests PRs that add or change tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: REST API Event Handler Rejects Valid APIGatewayProxyEvent

2 participants